Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly fail login() promise on login failure #3727

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Correctly fail login() promise on login failure #3727

merged 2 commits into from
Apr 26, 2023

Conversation

niloc132
Copy link
Member

Fixes #3707

@niloc132 niloc132 added this to the Apr 2023 milestone Apr 24, 2023
@niloc132 niloc132 requested a review from mofojed April 24, 2023 17:19
mofojed
mofojed previously approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to update the plugin to display the error a little bit nicer.

@niloc132 niloc132 merged commit 1ff6aee into deephaven:main Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
authentication jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
Apr 2023
Development

Successfully merging this pull request may close these issues.

Login hangs if incorrect pre-shared key used
2 participants
@niloc132 @mofojed