ParallelWhere: Prevent Race Between Interrupt and Child Running #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
cpwright
approved these changes
May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a 5m timeout on the test; because why shouldn't we have some failsafe?
Here is a link to the final nightly run that targeted 18 attempts at reproducing: https://github.com/nbauernfeind/deephaven-core/actions/runs/4874961958
Statistically I was getting about 25% failures per run. This was 2 of 18 each without failures. I also caught the codepaths in use (with the child already cancelled).