-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaClient: Encode Packed Booleans Instead of Reinterpretted Bytes #3812
Conversation
java-client/flight/src/main/java/io/deephaven/client/impl/VectorHelper.java
Outdated
Show resolved
Hide resolved
May be worthwhil to try and fix #1373, here is the commented out code updated from // TODO (deephaven-core#1373): Hook up doPut integration unit testing
@Test
public void doPutStream() throws Exception {
try (
final TableHandle ten = flightSession.session().execute(TableSpec.empty(10).view("I=i"));
// DoGet
final FlightStream tenStream = flightSession.stream(ten);
// DoPut
final TableHandle tenAgain = flightSession.putExport(tenStream)) {
assertThat(tenAgain.response().getSchemaHeader()).isEqualTo(ten.response().getSchemaHeader());
}
}
@Test
public void doPutNewTable() throws TableHandleException, InterruptedException {
try (final TableHandle newTableHandle = flightSession.putExport(newTable(), bufferAllocator)) {
// ignore
}
} It appears the flight client is blocking on getResult; it may be a factor that this is an in-process setup?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. Looks like spotless in complaining. We probably want to push this through nightlies?
server/src/test/java/io/deephaven/server/runner/DeephavenApiServerTestBase.java
Outdated
Show resolved
Hide resolved
java-client/flight-dagger/src/test/java/io/deephaven/client/DeephavenFlightSessionTest.java
Outdated
Show resolved
Hide resolved
if (UpdateGraphProcessor.DEFAULT.isUnitTestModeAllowed()) { | ||
UpdateGraphProcessor.DEFAULT.enableUnitTestMode(); | ||
UpdateGraphProcessor.DEFAULT.resetForUnitTests(false); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure exactly the pattern we are supposed to be using - will defer to @rcaudy
Fixes #3799.
Fixes #1373.