Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py classifiers #3825

Merged
merged 1 commit into from
May 11, 2023
Merged

Update setup.py classifiers #3825

merged 1 commit into from
May 11, 2023

Conversation

devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith added this to the May 2023 milestone May 11, 2023
@devinrsmith devinrsmith self-assigned this May 11, 2023
@devinrsmith
Copy link
Member Author

Did a quick look at numpy and pandas, and they both have the classifiers:

        'Programming Language :: Python',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3 :: Only',

in addition to the version specific ones.

@devinrsmith
Copy link
Member Author

I'm not sure why we ever had the classifier Topic :: Software Development :: Build Tools ?

jmao-denver
jmao-denver approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith merged commit 2438945 into deephaven:main May 11, 2023
@devinrsmith devinrsmith deleted the update-setup-py-classifiers branch May 11, 2023 15:38
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

@rcaudy rcaudy rcaudy approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@devinrsmith devinrsmith

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@devinrsmith @jmao-denver @rcaudy