Check for overflows when calling jpy getIntValue #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
reviewed
May 16, 2023
Integrations/src/main/java/io/deephaven/integrations/python/PythonValueGetter.java
Outdated
Show resolved
Hide resolved
Integrations/src/main/java/io/deephaven/integrations/python/PythonValueGetter.java
Show resolved
Hide resolved
Integrations/src/main/java/io/deephaven/integrations/python/PythonValueGetter.java
Outdated
Show resolved
Hide resolved
Integrations/src/main/java/io/deephaven/integrations/python/PythonValueGetter.java
Outdated
Show resolved
Hide resolved
jmao-denver
force-pushed
the
3716-pyobj-getIntValue-overflow
branch
from
f4d0a5a
to
0c41ad4
Compare
devinrsmith
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3716
related to jpy-consortium/jpy#98
linked to: #3598
Note:
PyObject.getIntValue and family are also used in the generated formula code to cast a PyObject to a specified 'integer' type. Since casting in Java doesn't check for overflow, these use cases are not included as part of the change.