Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to get underlying data array from writable chunks. #3845

Merged
merged 4 commits into from
May 18, 2023
Merged

Add methods to get underlying data array from writable chunks. #3845

merged 4 commits into from
May 18, 2023

Conversation

cpwright
Copy link
Contributor

No description provided.

@cpwright cpwright requested a review from rcaudy May 17, 2023 16:57
rcaudy
rcaudy reviewed May 18, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested cleanups to JavaDocs and code (since spotless won't touch these files), as well as a rename from offset() to arrayOffset(). Also changed unit test to use arrayOffset() instead of bare access to offset afforded by package-private access.

engine/chunk/src/main/java/io/deephaven/chunk/WritableCharChunk.java Outdated Show resolved Hide resolved
engine/chunk/src/test/java/io/deephaven/chunk/TestCharChunk.java Outdated Show resolved Hide resolved
@rcaudy rcaudy added this to the May 2023 milestone May 18, 2023
@rcaudy rcaudy added feature request New feature or request query engine core Core development tasks labels May 18, 2023
@rcaudy rcaudy enabled auto-merge (squash) May 18, 2023 20:17
@rcaudy rcaudy merged commit d09dc31 into deephaven:main May 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@cpwright cpwright

Labels
core Core development tasks feature request New feature or request NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. query engine
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@cpwright @rcaudy