Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not break snapshots into multiple record batches (yet) #3866

Merged
merged 4 commits into from
May 26, 2023
Merged

Do not break snapshots into multiple record batches (yet) #3866

merged 4 commits into from
May 26, 2023

Conversation

nbauernfeind
Copy link
Member

Fixes #3862.

@nbauernfeind nbauernfeind added bug Something isn't working barrage NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels May 23, 2023
@nbauernfeind nbauernfeind added this to the May 2023 milestone May 23, 2023
@nbauernfeind nbauernfeind self-assigned this May 23, 2023
rcaudy
rcaudy previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please make sure this is tested before merge

niloc132
niloc132 previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to also fix #3863.

@nbauernfeind nbauernfeind dismissed stale reviews from niloc132 and rcaudy via a40b8a9 May 25, 2023 20:32
niloc132
niloc132 previously approved these changes May 25, 2023
View reviewed changes
@rcaudy rcaudy merged commit feb4998 into deephaven:main May 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@lbooker42 lbooker42 Awaiting requested review from lbooker42

@niloc132 niloc132 Awaiting requested review from niloc132

Assignees

@nbauernfeind nbauernfeind

Labels
barrage bug Something isn't working NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

Error when JS API subscribes to large tables
3 participants
@nbauernfeind @niloc132 @rcaudy