Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typed asOfJoin, delegate aj/raj #3899

Merged
merged 7 commits into from
Jun 1, 2023
Merged

Add typed asOfJoin, delegate aj/raj #3899

merged 7 commits into from
Jun 1, 2023

Conversation

devinrsmith
Copy link
Member

Partial #3692

@devinrsmith devinrsmith added this to the May 2023 milestone May 31, 2023
@devinrsmith devinrsmith requested a review from rcaudy May 31, 2023 22:14
@devinrsmith devinrsmith self-assigned this May 31, 2023
@rcaudy
Copy link
Member

rcaudy commented Jun 1, 2023

Per our other discussion, we want to reverse the directionality of match rules to better express what happens. That is, we want aj to use GT and GEQ, raj to use LT and LEQ.

rcaudy
rcaudy reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on the direction change

java-client/session/src/main/java/io/deephaven/client/impl/BatchTableRequestBuilder.java Outdated Show resolved Hide resolved
@devinrsmith devinrsmith requested a review from rcaudy June 1, 2023 18:13
@devinrsmith devinrsmith requested a review from rcaudy June 1, 2023 18:34
@rcaudy rcaudy merged commit 2154d48 into deephaven:main Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
@devinrsmith devinrsmith deleted the nightly/as-of-join branch June 1, 2023 21:08
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2694
Conceptual: https://github.com/deephaven/deephaven.io/issues/2693
Reference: https://github.com/deephaven/deephaven.io/issues/2695
Blog: https://github.com/deephaven/deephaven.io/issues/2696

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@jmao-denver jmao-denver Awaiting requested review from jmao-denver jmao-denver is a code owner

Assignees

@devinrsmith devinrsmith

Labels
breaking DocumentationNeeded qst ReleaseNotesNeeded Release notes are needed table api
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@devinrsmith @rcaudy @deephaven-internal