Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pydeephaven for aj/raj #3914

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Update pydeephaven for aj/raj #3914

merged 1 commit into from
Jun 2, 2023

Conversation

devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith added this to the May 2023 milestone Jun 2, 2023
@devinrsmith devinrsmith self-assigned this Jun 2, 2023
@devinrsmith
Copy link
Member Author

This has been tested w/ the unittestst and examples from py/client/README.md

rcaudy
rcaudy reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmao-denver
jmao-denver approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith enabled auto-merge (squash) June 2, 2023 17:18
@devinrsmith devinrsmith merged commit a4676d8 into deephaven:main Jun 2, 2023
@devinrsmith devinrsmith deleted the as-of-join-pydeephaven-client branch June 2, 2023 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2714
Conceptual: https://github.com/deephaven/deephaven.io/issues/2717
Reference: https://github.com/deephaven/deephaven.io/issues/2716
Blog: https://github.com/deephaven/deephaven.io/issues/2715

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy left review comments

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@devinrsmith devinrsmith

Labels
breaking DocumentationNeeded python-client ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@devinrsmith @deephaven-internal @jmao-denver @rcaudy