Fix RowRedirectionLockFreeTest: Prevent Succeeding If Thread Fails #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
|
This is an example of the general issue I raised in #3930
I think improving this specific test in this way is good, but hoping we have a more robust solution in the future. |
rcaudy
reviewed
Jun 5, 2023
engine/table/src/test/java/io/deephaven/engine/table/impl/util/RowRedirectionLockFreeTest.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one issue @devinrsmith pointed out in slack about the nightly failures.
Here is a nightly with this fix: https://github.com/nbauernfeind/deephaven-core/actions/runs/5178849528