Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect Java method name in blink_to_append_only, and add a unit test #3967

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix incorrect Java method name in blink_to_append_only, and add a unit test #3967

merged 1 commit into from
Jun 9, 2023

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Jun 9, 2023 •
edited
Loading

Fixes #3966

@rcaudy rcaudy added this to the June 2023 milestone Jun 9, 2023
@rcaudy rcaudy requested a review from chipkent as a code owner June 9, 2023 18:41
@rcaudy rcaudy self-assigned this Jun 9, 2023
@rcaudy rcaudy requested a review from jmao-denver as a code owner June 9, 2023 18:41
jmao-denver
jmao-denver approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcaudy rcaudy enabled auto-merge (squash) June 9, 2023 18:45
@rcaudy rcaudy merged commit cfebcb8 into deephaven:main Jun 9, 2023
@rcaudy rcaudy deleted the rwc-fix-py-blink-to-append branch June 9, 2023 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working NoDocumentationNeeded python python-server-side ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

blink_to_append_only and stream_to_append_only are broken
2 participants
@rcaudy @jmao-denver