Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Barrage performance tables to use blink tables #4116

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Update Barrage performance tables to use blink tables #4116

merged 1 commit into from
Jul 3, 2023

Conversation

devinrsmith
Copy link
Member

Fixes #4114

@devinrsmith devinrsmith added this to the July 2023 milestone Jun 30, 2023
@devinrsmith devinrsmith requested a review from rcaudy June 30, 2023 20:59
@devinrsmith devinrsmith self-assigned this Jun 30, 2023
rcaudy
rcaudy approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Wouldn't mind deleting the deprecated class, though.

engine/table/src/main/java/io/deephaven/engine/tablelogger/impl/memory/MemoryTableLogger.java
*/
@Deprecated(since = "0.26.0", forRemoval = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What still uses this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in DHC, but checking w/ DHE. Technically, users could too.

@devinrsmith devinrsmith merged commit 769b356 into deephaven:main Jul 3, 2023
@devinrsmith devinrsmith deleted the barrage-performance-blink-tables branch July 3, 2023 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2867
Reference: https://github.com/deephaven/deephaven.io/issues/2866

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@devinrsmith devinrsmith

Labels
barrage DocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.

Replace Barrage performance tables with blink tables
3 participants
@devinrsmith @deephaven-internal @rcaudy