Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationInitializer usage bug fix and associated cleanups #4976

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Dec 21, 2023

Fixes the proximate cause of #4975

  • Get rid of inappropriate OperationInitializer usage from WhereListener
  • Clean up direct OperationInitializationThreadPool usage
  • Rename OperationInitializationPoolJobScheduler to OperationInitializerJobScheduler
  • Rename ExecutionContext.getInitializer to ExecutionContext.getOperationInitializer
  • Move PeriodicUpdateGraph.refreshThread construction to start()

…r. Clean up direct OperationInitializationThreadPool usage. Rename OperationInitializationPoolJobScheduler.java to OperationInitializerJobScheduler. Rename ExecutionContext.getInitializer to ExecutionContext.getOperationInitializer.
@rcaudy rcaudy added bug Something isn't working query engine core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Dec 21, 2023
@rcaudy rcaudy added this to the December 2023 milestone Dec 21, 2023
@rcaudy rcaudy self-assigned this Dec 21, 2023
nbauernfeind
nbauernfeind previously approved these changes Dec 22, 2023
… to be more forceful for WhereListener, matching similar logic in SelectOrUpdateListener
nbauernfeind
nbauernfeind previously approved these changes Dec 22, 2023
Copy link
Member

@nbauernfeind nbauernfeind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch still tests correctly.

@rcaudy rcaudy merged commit 18c9f81 into deephaven:main Dec 22, 2023
19 checks passed
@rcaudy rcaudy deleted the rwc-fix-opinit branch December 22, 2023 23:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants