Run JS API unit tests and integration tests in the Gradle build

buildSrc/src/main/groovy/GwtTools.groovy

@@ -1,6 +1,7 @@
 import de.esoco.gwt.gradle.GwtLibPlugin
 import de.esoco.gwt.gradle.GwtPlugin
 import de.esoco.gwt.gradle.extension.GwtExtension
+import de.esoco.gwt.gradle.task.GwtCheckTask
 import de.esoco.gwt.gradle.task.GwtCompileTask
 import groovy.transform.CompileStatic
 import org.gradle.api.Project
@@ -36,6 +37,10 @@ class GwtTools {
             GwtCompileTask gwtc ->
                 applyModuleSettings p, gwtc, module,description
         }
+        p.tasks.withType(GwtCheckTask).configureEach {t ->
+            t.mustRunAfter(p.tasks.withType(GwtCompileTask))
+            t.onlyIf { false }
+        }
 
         return ext
     }
@@ -70,8 +75,6 @@ class GwtTools {
         gwtDev && gwtc.doFirst {
             gwtc.logger.quiet('Running in gwt dev mode; saving source to {}/dh/src', extras)
         }
-
-        p.tasks.findByName('gwtCheck')?.enabled = false
     }
 
     static void applyDefaults(Project p, GwtExtension gwt, boolean compile = false) {
@@ -110,31 +113,13 @@ class GwtTools {
                 maxHeapSize = "1024m"
                 minHeapSize = "512m"
             }
-
-            gwt.dev.with {
-                /** The ip address of the code server. */
-                bindAddress = "127.0.0.1"
-                /** The port where the code server will run. */
-                port = 9876
-                /** Specifies Java source level ("1.6", "1.7").
-                 sourceLevel = "1.8"
-                 /** The level of logging detail (ERROR, WARN, INFO, TRACE, DEBUG, SPAM, ALL) */
-                logLevel = "INFO"
-                /** Emit extra information allow chrome dev tools to display Java identifiers in many placesinstead of JavaScript functions. (NONE, ONLY_METHOD_NAME, ABBREVIATED, FULL) */
-                methodNameDisplayMode = "NONE"
-                /** Where to write output files */
-                war = warPath
-//                    extraArgs = ["-firstArgument", "-secondArgument"]
-            }
-
-
         }
     }
 
     static void addGeneratedSources(Project project, GwtCompileTask gwtc) {
         if (project.configurations.getByName(JavaPlugin.ANNOTATION_PROCESSOR_CONFIGURATION_NAME).dependencies) {
             (gwtc.src as ConfigurableFileCollection).from(
-                (project.tasks.getByName(JavaPlugin.COMPILE_JAVA_TASK_NAME) as JavaCompile).options.annotationProcessorGeneratedSourcesDirectory
+                (project.tasks.getByName(JavaPlugin.COMPILE_JAVA_TASK_NAME) as JavaCompile).options.generatedSourceOutputDirectory
             )
         }
         project.configurations.getByName(JavaPlugin.COMPILE_CLASSPATH_CONFIGURATION_NAME).allDependencies.withType(ProjectDependency)*.dependencyProject*.each {

web/client-api/client-api.gradle

@@ -1,5 +1,11 @@
+import com.bmuschko.gradle.docker.tasks.container.DockerCreateContainer
+import com.bmuschko.gradle.docker.tasks.container.DockerRemoveContainer
+import com.bmuschko.gradle.docker.tasks.container.DockerStartContainer
+import io.deephaven.tools.docker.WaitForHealthyContainer
+
 plugins {
     id 'io.deephaven.project.register'
+    id 'io.deephaven.deephaven-in-docker'
 }
 
 apply from: "$rootDir/gradle/web-client.gradle"
@@ -8,6 +14,7 @@ configurations {
     js
     dts
     typescriptDoclet
+    testImplementation.extendsFrom junit
 }
 
 dependencies {
@@ -20,6 +27,8 @@ dependencies {
     implementation 'com.vertispan.nio:gwt-nio:1.0-alpha-1'
 
     js project(path: ':proto:raw-js-openapi', configuration: 'js')
+
+    testImplementation 'org.seleniumhq.selenium:selenium-remote-driver:4.16.1'
 }
 Classpaths.inheritElemental(project, 'elemental2-core', 'implementation')
 Classpaths.inheritElemental(project, 'elemental2-promise', 'implementation')
@@ -57,6 +66,78 @@ artifacts {
     }
 }
 
-project.tasks.getByName('quick').dependsOn project.tasks.withType(de.esoco.gwt.gradle.task.GwtCompileTask)
+def gwtUnitTest = tasks.register('gwtUnitTest', Test) { t ->
+    t.systemProperties = [
+            'gwt.args': "-runStyle HtmlUnit -ea -style PRETTY -war ${layout.buildDirectory.dir('unitTest-war').get().asFile.absolutePath}",
+            'gwt.persistentunitcachedir':layout.buildDirectory.dir('unitTest-unitCache').get().asFile.absolutePath,
+    ]
+    t.include '**/ClientUnitTestSuite.class'
+    t.useJUnit()
+    t.scanForTestClasses = false
+}
+
+// start a grpc-api server
+String randomSuffix = UUID.randomUUID().toString();
+deephavenDocker {
+    envVars.set([
+            'START_OPTS':'-Xmx512m -DAuthHandlers=io.deephaven.auth.AnonymousAuthenticationHandler'
+    ])
+    containerName.set "dh-server-for-js-${randomSuffix}"
+    networkName.set "js-test-network-${randomSuffix}"
+}
+
+def seleniumContainerId = "selenium-${randomSuffix}"
+
+def createSelenium = tasks.register('createSelenium', DockerCreateContainer) { t ->
+    t.containerName.set(seleniumContainerId)
+    t.targetImageId('selenium/standalone-firefox:4.16.1-20231219')// TODO create a registry entry for this
+    t.hostConfig.shmSize.set(2L * 1024 * 1024 * 1024)
+    t.hostConfig.portBindings.set(['4444:4444', '7900:7900'])//TODO don't expose 7900, and make 4444 dynamic
+    t.hostConfig.network.set('host')
+}
+def startSelenium = tasks.register('startSelenium', DockerStartContainer) {t ->
+    t.dependsOn(createSelenium)
+    t.containerId.set(seleniumContainerId)
+}
+def seleniumHealthy = project.tasks.register('seleniumHealthy', WaitForHealthyContainer) { task ->
+    task.dependsOn startSelenium
+
+    task.awaitStatusTimeout.set 120
+    task.checkInterval.set 100
 
-apply from: "$rootDir/gradle/web-gwt-test.gradle"
+    task.containerId.set(seleniumContainerId)
+}
+def stopSelenium = project.tasks.register('stopSelenium', DockerRemoveContainer) { task ->
+    task.dependsOn startSelenium
+    task.targetContainerId seleniumContainerId
+    task.force.set true
+    task.removeVolumes.set true
+}
+// before/after:
+// docker run -d -p 4444:4444 -p 7900:7900 --shm-size="2g" --net=host selenium/standalone-firefox:4.16.1-20231219
+
+def gwtIntegrationTest = tasks.register('gwtIntegrationTest', Test) { t ->
+    t.dependsOn(deephavenDocker.portTask, seleniumHealthy)
+    t.finalizedBy(deephavenDocker.endTask, stopSelenium)
+    doFirst {
+        def webdriverUrl = 'http://localhost:4444/'
+        t.systemProperty('gwt.args', "-runStyle io.deephaven.web.junit.RunStyleRemoteWebDriver:${webdriverUrl}?firefox -ea -style PRETTY -setProperty dh.server=http://localhost:${deephavenDocker.port.get()} -war ${layout.buildDirectory.dir('integrationTest-war').get().asFile.absolutePath}")
+        t.classpath += tasks.getByName('gwtCompile').src
+    }
+    t.finalizedBy(deephavenDocker.endTask)
+    t.systemProperties = [
+            'gwt.persistentunitcachedir':layout.buildDirectory.dir('integrationTest-unitCache').get().asFile.absolutePath,
+    ]
+    t.include '**/ClientIntegrationTestSuite.class'
+    t.useJUnit()
+    t.scanForTestClasses = false
+}
+
+tasks.named('check').configure {
+    dependsOn(gwtUnitTest, gwtIntegrationTest)
+}
+
+test {
+    // Configure jvm-only tests to not run any GWT-only tests
+    exclude '**/*TestGwt.class', '**/*TestSuite.class'
+}

web/client-api/src/main/java/io/deephaven/web/client/api/JsColumnStatistics.java

@@ -12,6 +12,7 @@
 import jsinterop.annotations.JsIgnore;
 import jsinterop.annotations.JsMethod;
 import jsinterop.annotations.JsProperty;
+import jsinterop.annotations.JsType;
 
 import java.util.Arrays;
 import java.util.HashMap;

web/client-api/src/main/java/io/deephaven/web/client/api/JsTable.java

@@ -45,6 +45,7 @@
 import io.deephaven.web.client.api.batch.TableConfig;
 import io.deephaven.web.client.api.console.JsVariableType;
 import io.deephaven.web.client.api.filter.FilterCondition;
+import io.deephaven.web.client.api.filter.FilterValue;
 import io.deephaven.web.client.api.input.JsInputTable;
 import io.deephaven.web.client.api.lifecycle.HasLifecycle;
 import io.deephaven.web.client.api.state.StateCache;
@@ -71,6 +72,8 @@
 import io.deephaven.web.shared.fu.JsProvider;
 import io.deephaven.web.shared.fu.JsRunnable;
 import io.deephaven.web.shared.fu.RemoverFn;
+import javaemul.internal.annotations.DoNotAutobox;
+import jsinterop.annotations.JsIgnore;
 import jsinterop.annotations.JsMethod;
 import jsinterop.annotations.JsNullable;
 import jsinterop.annotations.JsOptional;
@@ -594,6 +597,11 @@ public JsArray<FilterCondition> applyFilter(FilterCondition[] filter) {
     @TsUnion
     @JsType(name = "?", namespace = JsPackage.GLOBAL, isNative = true)
     public interface CustomColumnArgUnionType {
+        @JsOverlay
+        static CustomColumnArgUnionType of(@DoNotAutobox Object value) {
+            return Js.cast(value);
+        }
+
         @JsOverlay
         default boolean isString() {
             return (Object) this instanceof String;
@@ -1762,8 +1770,8 @@ public void handleSnapshot(TableTicket handle, TableSnapshot snapshot) {
                 viewportRows.size());
     }
 
-
-    protected void processSnapshot() {
+    @JsIgnore
+    public void processSnapshot() {
         try {
             if (debounce == null) {
                 JsLog.debug("Skipping snapshot b/c debounce is null");

web/client-api/src/main/java/io/deephaven/web/client/api/WorkerConnection.java

@@ -1437,7 +1437,7 @@ private void flush() {
                 // TODO #188 support minUpdateIntervalMs
                 double serializationOptionsOffset = BarrageSubscriptionOptions
                         .createBarrageSubscriptionOptions(subscriptionReq, ColumnConversionMode.Stringify, true, 1000,
-                                0, 0);
+                                0, 1_000_000_000);
                 double tableTicketOffset =
                         BarrageSubscriptionRequest.createTicketVector(subscriptionReq, state.getHandle().getTicket());
                 BarrageSubscriptionRequest.startBarrageSubscriptionRequest(subscriptionReq);