Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API should expose if a table is refreshing #4999

Merged
merged 48 commits into from
Jan 18, 2024
Merged

JS API should expose if a table is refreshing #4999

merged 48 commits into from
Jan 18, 2024

Conversation

niloc132
Copy link
Member

Fixes #4485

niloc132 added 28 commits November 2, 2023 12:12
@niloc132
Hacked together tests
b048f9c
@niloc132
Tests build, but do not pass
c05823a
@niloc132
bad idea: opt in to a huge payload from the server - should instead
30d1df4 
replace this with handling many smaller snapshots
@niloc132
quick hack to decrease treemap costs - fix with non-random loading
47a68cd
@niloc132
spotless for ci
ea53236
@niloc132
fix regression in formatting longs
e8ddd50
@niloc132
integration tests run, fail
5f8cb54
@niloc132
Tests are passing in manual mode, except filter setup
a855985
@niloc132
Tidy up tests, disable filter tests for now
06a17a5
@niloc132
Add additional integration tests
354fd48
@niloc132
null values test
d8ad542
@niloc132
POtential totals table test
9df4859
@niloc132
Attempt at reusing code from gwt-core test
d9da1ca
@niloc132
Nearly working tests from gradle, with TODOs
6e6326d
@niloc132
Checkpoint commit, gwt test tasks pass, check fails
92e6f3a
@niloc132
Dirty hack to avoid esoco's assumption that compile must run after test
37639a0
@niloc132
Don't run gwt tests with in quick
03939d9
@niloc132
Remove unused build file, raise timeout on a test
0d15ac3
@niloc132
Merge branch 'main' into js-flight
49b9b95
@niloc132
Clean up readability, use a registry image
0d02ff3
@niloc132
tidy things up to working in CI
dd54ea8
@niloc132
Revert SubscriptionTableData, WorkerConnection
e16cbb7
@niloc132
Final cleanup (?)
4af1341
@niloc132
Add server support for indicating that a hierarchical table is
8cd5215 
refreshing
@niloc132
Populate simpler js types to expose isRefreshing()
fca4cb0
@niloc132
Update generated gwt bindings
3928d91
@niloc132
Update other generated proto code
2e5ff31
@niloc132
Finish off the feature, cleanup
7986f4a
@niloc132 niloc132 requested a review from jcferretti as a code owner January 17, 2024 21:09
mofojed
mofojed approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though now I'm wondering why I specified JsTable.isRefreshing as opposed to something like JsTable.isStatic. Would isStatic be a better name? Could see isRefreshing being misconstrued as something else. Thoughts?

@niloc132
Copy link
Member Author

Looks good, though now I'm wondering why I specified JsTable.isRefreshing as opposed to something like JsTable.isStatic. Would isStatic be a better name? Could see isRefreshing being misconstrued as something else. Thoughts?

It looks like the server api exposes this as isRefreshing(), so it makes sense to me for the js client api to do the same - that's probably where you got the name?

@niloc132 niloc132 merged commit ca5751c into deephaven:main Jan 18, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

@mofojed mofojed mofojed approved these changes

@devinrsmith devinrsmith devinrsmith approved these changes

@nbauernfeind nbauernfeind Awaiting requested review from nbauernfeind nbauernfeind is a code owner

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

@jcferretti jcferretti Awaiting requested review from jcferretti

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees
No one assigned
Labels
grpc jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
1. January 2024 (end of month)
Development

Successfully merging this pull request may close these issues.

Expose isRefreshing property through JS API
5 participants
@niloc132 @jmao-denver @mofojed @rcaudy @devinrsmith