Add a local copy of build-dependencies.sh for cpp-client, and add a PR check that is kept up to date. #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R check that is kept up to date.
jcferretti
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
LGTM. Thanks for this proposal. I'm assuming you tested a different file contents to ensure the cmp causes cpp-client to fail. Please make sure @rbasralian is happy too.
| (this script is also used from our automated tools, to generate a docker image to | ||
| support tests runs; that's why it lives in a separate repo). | ||
| The script downloads, builds and installs the dependent libraries | ||
| The `build-dependencies.sh` script in this directory downloads, |
There was a problem hiding this comment.
We could have markdown link to it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the actual intent of #5071 in a better way
(implements the comment #5071 (comment))