Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free performance data when ExportObject is released #5480

Merged
merged 1 commit into from
May 16, 2024
Merged

Free performance data when ExportObject is released #5480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/src/main/java/io/deephaven/server/session/SessionState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,6 +1141,7 @@ protected synchronized void destroy() {
if (!(caughtException instanceof StatusRuntimeException)) {
caughtException = null;
}
queryPerformanceRecorder = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal here? I assume we're not keeping hard refs to the ExportObject once it's destroyed most of the time, anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this time, we do keep hard refs to ExportObjects within a session so that we can tell if an unrecognized export ID is either stale RELEASED ("sorry, you raced but you just missed it, that was already released") or UNKNOWN ("hmm, never seen that before, you probably raced it and won, so we'll wait until it appears").

The linked issue mentions a strategy to handle this, with a RowSet for known-released objects, so that we no longer need to keep the ExportObject itself around.

}

/**
Expand Down
Loading