Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate properties to netty-app from jetty-app and update proj status #5505

Merged
merged 3 commits into from
May 17, 2024

Conversation

niloc132
Copy link
Member

No description provided.

@niloc132 niloc132 added this to the 3. May 2024 milestone May 17, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this file is now exactly the same as server/jetty-app/build.gradle, if you replace "jetty" with "netty".
Is there a way to avoid the copy-paste and just share the content with a parametrized gradle file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite exactly - there's a different dependency (netty-app vs jetty-app) and different application plugin configuration (they call different main()s, in netty.NettyMain vs jetty.JettyMain). Could probably factor out much of the rest though to some kind of ServerPlugin if we wanted, or do some subprojects nonsense to force both to use the same properties

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, yes exactly, if you do a case-preserving search replace. ;-)

@niloc132 niloc132 merged commit 5c8ac51 into deephaven:main May 17, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants