Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ client: clean up some tests #5687

Merged
merged 1 commit into from
Jun 27, 2024
Merged

C++ client: clean up some tests #5687

merged 1 commit into from
Jun 27, 2024

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Jun 27, 2024

This PR is just doing some mild cleanup:

  1. Remove dead code
  2. In validation_test remove a call to a helper method. Formerly we had the test entry point calling TestSelects which called TestSelectsHelper. Now we have the test entry point doing some work, then calling TestSelectsHelper.
  3. Likewise for TestWheres and TestWheresHelper.
  4. In validation_test we now use the printing routines provided by the fmt library (which know how to print a vector) rather than explicitly making our own comma separated list

@kosak kosak self-assigned this Jun 27, 2024
@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Jun 27, 2024
@kosak kosak requested a review from jcferretti June 27, 2024 01:46
@kosak kosak enabled auto-merge (squash) June 27, 2024 02:07
@kosak kosak merged commit a3d2a3e into deephaven:main Jun 27, 2024
16 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@kosak kosak deleted the kosak_fixtests branch June 27, 2024 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants