-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove java classpath conventions #5724
Merged
devinrsmith
merged 36 commits into
deephaven:main
from
devinrsmith:remove-java-classpath-conventions
Jul 8, 2024
Merged
build: Remove java classpath conventions #5724
devinrsmith
merged 36 commits into
deephaven:main
from
devinrsmith:remove-java-classpath-conventions
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
build
NoDocumentationNeeded
NoReleaseNotesNeeded
No release notes are needed.
labels
Jul 5, 2024
rcaudy
reviewed
Jul 5, 2024
rcaudy
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our custom configuration hierarchy, historically inherited from the "fishlib" days.
Follow-up to #5683
Note: unlike #5683, this migration does not aim to preserve the exact configuration dependencies that were inherited in the java-classpath-conventions hierarchy. The configuration conventions were overly broad, and didn't represent the real dependencies that each project has. As part of this, our dependency on
org.jetbrains:annotations
changed from an implementation dependency (inherited through thefishBase
configuration) to a compileOnly dependency to better reflect how we actually depend on it. We might expect that the jetbrains annotations would be removed from our application runtime classpath entirely, but that is not the case - it turns out that one of our transitive dependencies has a runtime dependency on it:In this case, it has the visible effect of "downgrading" our runtime classpath from what was previously
org.jetbrains:annotations:24.0.0
toorg.jetbrains:annotations:13.0
. Arguably, this is the more correct runtime dependency to provide given it matches what the exact version the transitive library requests.