Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpp-client): Make build instructions more explicit about server step. #5766

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

jcferretti
Copy link
Member

No description provided.

@jcferretti jcferretti requested a review from kosak July 12, 2024 17:01
1. Get Deephaven running by following the instructions here:
1. To run the client tests (last step in this list), we will need a server.
Get Deephaven server ready by following the instructions below.
Note the server itself is only supported on linux at this time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the motivation for the change, but maybe we can be even more explicit.... * * * BOTH * * * here and in the Ubuntu instructions above. Really tripling-down on the explicitness:

Maybe text like

To actually use Deephaven, for example running these examples and unit tests, you will eventually need to have a server running. If you have an existing server running Deephaven Core, you should be able to connect to that. However, if you don't have one, you can follow the instructions here: https://deephaven.io/core/docs/how-to-guides/launch-build/ . Note that it is only possible to build a server on Linux. Building a server on Windows is not currently supported.

You can build and install client libraries, tests, and examples without having a server installed. However you will eventually need to connect a server when you want to run them.

@jcferretti jcferretti changed the title fix(cpp-client) Make build instructions more explicit about server step. fix(cpp-client): Make build instructions more explicit about server step. Jul 12, 2024
@jcferretti jcferretti enabled auto-merge (squash) July 12, 2024 19:09
@jcferretti jcferretti added this to the 0.36.0 milestone Jul 12, 2024
@jcferretti jcferretti self-assigned this Jul 12, 2024
@jcferretti jcferretti merged commit e5c27d5 into deephaven:main Jul 12, 2024
18 of 20 checks passed
@jcferretti jcferretti deleted the cfs-cpp-readme-server branch July 12, 2024 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants