Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JS API should pass date/number formatting to UI #6158

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Oct 1, 2024

Fixes #6120

@niloc132 niloc132 added jsapi NoDocumentationNeeded release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed labels Oct 1, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Oct 1, 2024
@niloc132 niloc132 self-assigned this Oct 1, 2024
Copy link
Contributor

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified formatting is working in the web UI with this change. Will let @nbauernfeind have final approval for the code

@niloc132 niloc132 merged commit d2873dd into deephaven:main Oct 1, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jsapi NoDocumentationNeeded release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number formatting not working
3 participants