Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: a new PartitionedTableService API in Python #6175

Merged
merged 45 commits into from
Nov 1, 2024
Merged

feat: a new PartitionedTableService API in Python #6175

merged 45 commits into from
Nov 1, 2024

Commits on Oct 21, 2024

  1. Define Py PartitionedTableServiceBackend intf

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    11c1a48 View commit details
    Browse the repository at this point in the history

  2. Skeleton work

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d7d81d0 View commit details
    Browse the repository at this point in the history

  3. Full pass through PythonTableDataService; no real barrage message dat… 

    …a reading yet
    @nbauernfeind
    nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4097aca View commit details
    Browse the repository at this point in the history

  4. Schema/TableDefinition creation

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    43960d0 View commit details
    Browse the repository at this point in the history

  5. Excerice existing_partitions

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    66fedf9 View commit details
    Browse the repository at this point in the history

  6. Implement remaining functions in Py wrapper

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6a2b50f View commit details
    Browse the repository at this point in the history

  7. Use the Java BiConsumer/Consumer func intf

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9868c79 View commit details
    Browse the repository at this point in the history

  8. Add range support in column_values()

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1af6997 View commit details
    Browse the repository at this point in the history

  9. Improve error handling for public API

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ddad0c9 View commit details
    Browse the repository at this point in the history

  10. Improve test backend

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    89ec201 View commit details
    Browse the repository at this point in the history

  11. Rename test module to be consistent

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7d26147 View commit details
    Browse the repository at this point in the history

  12. Implement arrow parsing for partition columns and column values.

    @nbauernfeind
    nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    32d5d04 View commit details
    Browse the repository at this point in the history

  13. Fix column ordering and tests

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    91df14a View commit details
    Browse the repository at this point in the history

  14. Add one more test

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6a6a2bf View commit details
    Browse the repository at this point in the history

  15. Update the test to fully exercice the backend

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2cc3367 View commit details
    Browse the repository at this point in the history

  16. Nate's Java Refactor

    @nbauernfeind
    nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    53db0c4 View commit details
    Browse the repository at this point in the history

  17. Paired Review

    @nbauernfeind
    nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7b8c8d3 View commit details
    Browse the repository at this point in the history

  18. Improve docstring and add new tests

    @jmao-denver @nbauernfeind
    jmao-denver authored and nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3ba7092 View commit details
    Browse the repository at this point in the history

  19. Minor Comment Clarification

    @nbauernfeind
    nbauernfeind committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c29282c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Fix broken test by unsubscribing via ReferenceCountedLivenessReferent… 

    …#destroy
    @nbauernfeind
    nbauernfeind committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c48d65d View commit details
    Browse the repository at this point in the history

  2. Fixup jmock TableLocation expectations

    @nbauernfeind
    nbauernfeind committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    bcd681e View commit details
    Browse the repository at this point in the history

  3. Fixup other jmock related test failures

    @nbauernfeind
    nbauernfeind committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    fbb377f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. More concise naming and new test scenarios

    @jmao-denver
    jmao-denver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    be7b0a5 View commit details
    Browse the repository at this point in the history

  2. Correct naming mistake

    @jmao-denver
    jmao-denver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    842c0a9 View commit details
    Browse the repository at this point in the history

  3. Ryan's feedback

    @nbauernfeind
    nbauernfeind committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bea6155 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge remote-tracking branch 'upstream/main' into 6171-py-TableService

    @nbauernfeind
    nbauernfeind committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ab74e91 View commit details
    Browse the repository at this point in the history

  2. merge related api change fix

    @nbauernfeind
    nbauernfeind committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6ca321c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
    @jmao-denver @rcaudy
    jmao-denver and rcaudy authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e31e7a3 View commit details
    Browse the repository at this point in the history

  2. Respond to Ryan's review comments

    @jmao-denver
    jmao-denver committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ee5c861 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Ryan's Rnd2 Feedback

    @nbauernfeind
    nbauernfeind committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    a587d80 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge remote-tracking branch 'upstream/main' into 6171-py-TableService

    @nbauernfeind
    nbauernfeind committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5288a7d View commit details
    Browse the repository at this point in the history

  2. Ryan's feedback from live demo

    @nbauernfeind
    nbauernfeind committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6fcfb97 View commit details
    Browse the repository at this point in the history

  3. Ryan's javadoc feedback

    @nbauernfeind
    nbauernfeind committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1e1626b View commit details
    Browse the repository at this point in the history

  4. More callbacks support in Python and ehn docs

    @jmao-denver
    jmao-denver committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    dbd26fd View commit details
    Browse the repository at this point in the history

  5. Minor docstring correction

    @jmao-denver
    jmao-denver committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    58c9f50 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Improve doc

    @jmao-denver
    jmao-denver committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    25386a8 View commit details
    Browse the repository at this point in the history

  2. Fix sphinx reference errors

    @jmao-denver
    jmao-denver committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7f05df4 View commit details
    Browse the repository at this point in the history

  3. Minor change to pydoc word choice

    @nbauernfeind
    nbauernfeind committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    18130de View commit details
    Browse the repository at this point in the history

  4. Ryan's 3rd Rnd Feedback

    @nbauernfeind
    nbauernfeind committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e5dd633 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update extensions/barrage/src/main/java/io/deephaven/extensions/barra… 

    …ge/util/PythonTableDataService.java

Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
    @nbauernfeind @rcaudy
    nbauernfeind and rcaudy authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    aef9cb4 View commit details
    Browse the repository at this point in the history

  2. Update extensions/barrage/src/main/java/io/deephaven/extensions/barra… 

    …ge/util/PythonTableDataService.java

Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
    @nbauernfeind @rcaudy
    nbauernfeind and rcaudy authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    efb05b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Ryan/Jianfeng Feedback

    @nbauernfeind
    nbauernfeind committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0ef147e View commit details
    Browse the repository at this point in the history

  2. Remove one extra space in docstring

    @jmao-denver
    jmao-denver committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ba0e6a8 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
    @nbauernfeind @rcaudy
    nbauernfeind and rcaudy authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e536e9e View commit details
    Browse the repository at this point in the history

  4. Ryan's suggested approach to ensure exactly one cancellation call

    @nbauernfeind
    nbauernfeind committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e0d8504 View commit details
    Browse the repository at this point in the history