-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename directory containing proto files #6379
Conversation
Technically breaking changes in the deephaven-proto-backplane-grpc jar:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things, look great.
py/client/setup.py
Outdated
@@ -37,7 +37,7 @@ def _compute_version(): | |||
description='The Deephaven Python Client', | |||
long_description=_get_readme(), | |||
long_description_content_type="text/markdown", | |||
packages=find_packages(exclude=("tests",)), | |||
packages=find_namespace_packages(exclude=("tests","examples","docs","build"),), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I see docs here, but docs/source/conf.py
is not being excluded, I'm guessing b/c it has a .py
extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the exclude isn't recursive, will investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory structure doesn't contain __init__.py
files, so I wonder if it is not treating it as a package and therefore not excluding. Just a wild guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we only want it to be a namespace, not a module - if we required that there be a __init__.py
file, that could conflict with other wheels from contributing to it (at least without stomping on each other).
Current test failure is a packaging-for-the-test issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4aead5e
In order to make directory structures usable for downstream projects seeking to add new services or messages that depend on our own proto files, ensure that we name/package consistently for all languages.
This may be a breaking change for some downstream consumers, but these changes should prevent needing to make future changes or add additional build steps. Two places this may impact applications:
pydeephaven.proto
todeephaven_core.proto
. The old import will continue to work in this release, but will warn the first time it is referenced.Fixes #6376