Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct rollup and tree snapshot code to wait for missed structural dependencies #6395

Merged
merged 7 commits into from
Nov 20, 2024
Merged

fix: Correct rollup and tree snapshot code to wait for missed structural dependencies #6395

merged 7 commits into from
Nov 20, 2024

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Nov 19, 2024

Fixes #6394

@rcaudy
Correct RollupTableImpl.maybeWaitForStructuralSatisfaction(): we were…
8ddafe6 
… mistakenly not waiting for the root
@rcaudy
Correct TreeTableImpl.maybeWaitForStructuralSatisfaction(): we were m…
6a189ee 
…istakenly not waiting for the sourceRowLookup in unfiltered cases
@rcaudy rcaudy added this to the 0.37.0 milestone Nov 19, 2024
@rcaudy rcaudy requested a review from cpwright November 19, 2024 01:22
@rcaudy rcaudy self-assigned this Nov 19, 2024
@rcaudy
Copy link
Member Author

rcaudy commented Nov 19, 2024

Ad-hoc testing with several variations of the reproducer from the issue suggests that this fix resolves the problem. Nightlies passed. Will work on one or more unit tests.

cpwright
cpwright previously approved these changes Nov 19, 2024
View reviewed changes
cpwright
cpwright previously approved these changes Nov 20, 2024
View reviewed changes
@rcaudy
Copy link
Member Author

rcaudy commented Nov 20, 2024

  • Correct RollupTableImpl.maybeWaitForStructuralSatisfaction(): we were mistakenly not waiting for the root
  • Correct TreeTableImpl.maybeWaitForStructuralSatisfaction(): we were mistakenly not waiting for the sourceRowLookup in unfiltered cases
  • Rename QueryTableTreeTest to TestHierarchicalTableSnapshots, and add tests for structural satisfaction fixes
  • Fix resource leak in HierarchicalTableImpl, address unnecessary copyPrev() usage, and address a spurious warning about lossy auto-increment

@rcaudy rcaudy enabled auto-merge (squash) November 20, 2024 19:30
@rcaudy rcaudy merged commit acdb6bf into deephaven:main Nov 20, 2024
16 checks passed
@rcaudy rcaudy deleted the rwc-rollupsat branch November 20, 2024 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpwright cpwright cpwright approved these changes

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded point_release_candidate query engine ReleaseNotesNeeded Release notes are needed rollup user-reported
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.

rollup <- lastby <- blink table appears to have stale data
2 participants
@rcaudy @cpwright