Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch figures when using pydeephaven #28

Closed
mofojed opened this issue Dec 1, 2023 · 0 comments · Fixed by #29
Closed

Fetch figures when using pydeephaven #28

mofojed opened this issue Dec 1, 2023 · 0 comments · Fixed by #29
Assignees
Labels
enhancement New feature or request

Comments

@mofojed
Copy link
Member

mofojed commented Dec 1, 2023

Right now when using pydeephaven, we cannot get a Figure and display it. We should be able to display it by providing the name of the variable, e.g. DeephavenWidget("p") to open a plot named p.
Note this would be much easier if we have the generic iframe widget: deephaven/web-client-ui#1629
Otherwise in addition to providing the variable name, they'll need to provide the variable type as well.

@mofojed mofojed added the enhancement New feature or request label Dec 1, 2023
@mofojed mofojed self-assigned this Dec 27, 2023
mofojed added a commit to mofojed/deephaven-ipywidgets that referenced this issue Dec 27, 2023
- Allow passing in an object by name and a session when using pydeephaven
- Fixes deephaven#28
- Tested using the following snippet:
```
from pydeephaven import Session
from deephaven_ipywidgets import DeephavenWidget
session = Session(auth_token="iris", auth_type="io.deephaven.authentication.psk.PskAuthenticationHandler")
session.run_script("""
from deephaven import empty_table
from deephaven.plot.figure import Figure
t = empty_table(100).update(["X=i", "Y=i*i"])
f = Figure().plot_xy(series_name="X vs Y", t=t, x="X", y="Y").show()
""")
display(DeephavenWidget("f", session=session))
```
@mofojed mofojed closed this as completed in c9399a3 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant