Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce typing on all things (no unknown typing) #97

Closed
Tracked by #50
mofojed opened this issue Oct 25, 2023 · 1 comment · Fixed by #302
Closed
Tracked by #50

Enforce typing on all things (no unknown typing) #97

mofojed opened this issue Oct 25, 2023 · 1 comment · Fixed by #302
Assignees
@jnumainville

Comments

@mofojed
Copy link
Member

mofojed commented Oct 25, 2023 •
edited
Loading

Focus on enabling it for deephaven.ui, but should be able to enable/disable it for other plugins in the repo.
@mofojed mofojed mentioned this issue Oct 25, 2023
Open
89 tasks
@jnumainville
Copy link
Collaborator

Could be added to pre-commit setup: https://github.com/pre-commit/mirrors-mypy

@jnumainville jnumainville mentioned this issue Nov 1, 2023
Closed
@jnumainville jnumainville mentioned this issue Feb 21, 2024
Merged
jnumainville added a commit that referenced this issue Feb 23, 2024
@jnumainville @mofojed
fix: Type fixes and require pyright (#302)
d5d003d 
Fixed remaining type issues and makes pyright a mandatory check via the
pre-commit.
Fixes #97

---------

Co-authored-by: Mike Bender <mikebender@deephaven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnumainville jnumainville

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mofojed @jnumainville