feat: First pass of ui.table functionality #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Oct 25, 2023
mofojed
commented
- Basic ui.table on_row_double_press functionality added
- Does not include the JS side that can handle the ui.table for now
- Basic ui.table on_row_double_press functionality added - Does not include the JS side that can handle the ui.table for now
jnumainville
requested changes
Oct 25, 2023
|
|
||
| self.source = empty_table(100).update(["X = i", "Y = i * 2"]) | ||
|
|
||
| def expect_render(self, ui_table, expected_props: dict[str, Any]): |
There was a problem hiding this comment.
missing type for ui_table
There was a problem hiding this comment.
I'm actually not really sure how to type this properly - if I import the type to early, I get an error when writing the tests (because importing deephaven before the server starts causes an error). Any idea how I should handle this?
There was a problem hiding this comment.
I think you can do this with postponed evaluation (PEP 563). Try importing from __future__ import annotations
https://stackoverflow.com/questions/70883599/type-hints-for-types-from-modules-which-may-not-be-loaded
There was a problem hiding this comment.
I think I've cleaned this up, though my editor is still complaining about it...
- Some tests were failing, incorrectly named functions - Added type annotation for UITable
jnumainville
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.