refactor: Clean up golden-layout css (#1338)

Reverts revert #1334 Applies #1322 w/ a fix for enterprise builds Still seems to need the ignore in `karma.config.cjs` though. Probably because the golden-layout package tests use old libraries
deephaven · Jun 2, 2023 · 210908c · 210908c
1 parent a25be7f
commit 210908c
Show file tree

Hide file tree

Showing 23 changed files with 318 additions and 482 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dashboard/src/PanelPlaceholder.scss b/packages/dashboard/src/PanelPlaceholder.scss
@@ -4,9 +4,13 @@
  display: flex;
  flex-direction: column;
  justify-content: center;
- padding: $spacer-3;
  min-height: 100%;
  max-height: 100%;
  text-align: center;
  overflow: hidden;
+
+ // add padding on an inner wrapper so it is included in max height of parent
+ div {
+ padding: $spacer-3;
+ }
 }
diff --git a/packages/dashboard/src/PanelPlaceholder.tsx b/packages/dashboard/src/PanelPlaceholder.tsx
@@ -11,7 +11,7 @@ const PanelPlaceholder = React.forwardRef(
  const component = LayoutUtils.getComponentNameFromPanel({ props });
  return (
  <div ref={ref} className="panel-placeholder">
- Component &quot;{component}&quot; is not registered.
+ <div>Component &quot;{component}&quot; is not registered.</div>
  </div>
  );
  }

diff --git a/packages/dashboard/src/layout/GoldenLayout.module.scss b/packages/dashboard/src/layout/GoldenLayout.module.scss