Skip to content

Commit

Permalink
feat: exposes editor-line-number-active-fg theme variable (#1833)
Browse files Browse the repository at this point in the history
Fixes issue with active line number looking bad in light theme.

- Exposes editor-line-number-active-fg as editor semanatic variable
- Sets to blue/black in light theme to match vs code light theme
approach
  • Loading branch information
dsmmcken authored Feb 27, 2024
1 parent 25d1c09 commit 448f0f0
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
--dh-color-editor-bg: var(--dh-color-content-bg);
--dh-color-editor-fg: var(--dh-color-gray-900);
--dh-color-editor-error-fg: var(--dh-color-visual-red);
--dh-color-editor-line-number-fg: var(--dh-color-gray-700);
--dh-color-editor-line-number-fg: var(--dh-color-gray-600);
--dh-color-editor-line-number-active-fg: var(--dh-color-gray-800);
--dh-color-editor-line-highlight-bg: var(--dh-color-gray-200);
--dh-color-editor-selection-bg: var(--dh-color-text-highlight);
--dh-color-editor-inactive-selection-bg: var(--dh-color-gray-300);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
--dh-color-editor-bg: var(--dh-color-content-bg);
--dh-color-editor-fg: var(--dh-color-gray-900);
--dh-color-editor-error-fg: var(--dh-color-visual-red);
--dh-color-editor-line-number-fg: var(--dh-color-gray-700);
--dh-color-editor-line-number-fg: var(--dh-color-cyan-1000);
--dh-color-editor-line-number-active-fg: var(--dh-color-gray-900);
--dh-color-editor-line-highlight-bg: var(--dh-color-gray-100);
--dh-color-editor-selection-bg: var(--dh-color-text-highlight);
--dh-color-editor-inactive-selection-bg: var(--dh-color-gray-200);
Expand Down
3 changes: 3 additions & 0 deletions packages/console/src/monaco/MonacoTheme.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@

//editor
editor-line-number-foreground: var(--dh-color-editor-line-number-fg);
editor-line-number-active-foreground: var(
--dh-color-editor-line-number-active-fg
);
editor-selection-background: var(--dh-color-editor-selection-bg);
editor-inactive-selection-background: var(
--dh-color-editor-inactive-selection-bg
Expand Down
2 changes: 2 additions & 0 deletions packages/console/src/monaco/MonacoUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@ class MonacoUtils {
MonacoTheme['editor-line-highlight-background'],
'editorLineNumber.foreground':
MonacoTheme['editor-line-number-foreground'],
'editorLineNumber.activeForeground':
MonacoTheme['editor-line-number-active-foreground'],
'editor.selectionBackground': MonacoTheme['editor-selection-background'],
'editor.inactiveSelectionBackground':
MonacoTheme['editor-inactive-selection-background'],
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 448f0f0

Please sign in to comment.