-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup divider is shown at the wrong column edge. #1062
Comments
The cause of this seems to be how we determine the last grouped column. We find the last column and then find the first occurrence of a column with that name. // In IrisGridRenderer.drawGroupedColumnLine
const lastGroupedColumn = groupedColumns[groupedColumns.length - 1];
const modelIndex = columns.findIndex(
c => c.name === lastGroupedColumn.name
); While it looks like the columns at the end of the list are in the right order, the ones in the beginning are not. For example, |
Description
Table is grouped by MyChar and MyString, however the border of the rollup is after mychar instead of myString
Wrong:
Grouping in the reverse order works correctly. Not sure the cause:
Steps to reproduce
Expected results
Border is after the last rolled up row.
Actual results
Border is shown in the incorrect location.
** NOTE **
Waiting for deephaven/deephaven-core#3477 should simplify the work needed on this issue.
Versions
Engine Version: 0.21.0
Web UI Version: 0.26.0
Java Version: 11.0.16
Barrage Version: 0.5.0
The text was updated successfully, but these errors were encountered: