Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a folder in file explorer panel sometimes fails to open or close it #1085

Closed
jason-wang24 opened this issue Feb 13, 2023 · 0 comments · Fixed by #1099
Closed

Clicking a folder in file explorer panel sometimes fails to open or close it #1085

jason-wang24 opened this issue Feb 13, 2023 · 0 comments · Fixed by #1099
Assignees
Labels
bug Something isn't working

Comments

@jason-wang24
Copy link
Contributor

Description

When single clicking or double clicking on a folder, it sometimes fails to change the state of the folder between open and closed.

Steps to reproduce

  1. Click a folder in the file explorer panel

Expected results
If the folder is open, the folder closes. If the folder is closed, the folder opens.

Actual results
Sometimes, the UI does not change.

Additional details and attachments
The bug seems to occur more frequently when the mouse is moving during the click.

@jason-wang24 jason-wang24 added bug Something isn't working triage Issue requires triage labels Feb 13, 2023
@jason-wang24 jason-wang24 self-assigned this Feb 13, 2023
@jason-wang24 jason-wang24 removed the triage Issue requires triage label Feb 13, 2023
jason-wang24 added a commit that referenced this issue Feb 23, 2023
… or close it (#1099)

Fixes #1085 

- isDragging was always set to true on itemMouseMove which prevented
onSelect from firing on even the slightest of mouse movements while
clicking
- Set isDragging to true only if the mouse moves at least 5 viewport
units in the X or Y direction between the mouseDown and mouseUp events
(attempted to get this value as close as possible to when the UI changes
to indicate dragging)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant