Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Formatting errors when selecting color of timestamp column #1091

Closed
dsmmcken opened this issue Feb 16, 2023 · 2 comments · Fixed by #1104
Closed

Conditional Formatting errors when selecting color of timestamp column #1091

dsmmcken opened this issue Feb 16, 2023 · 2 comments · Fixed by #1104
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Feb 16, 2023

Steps to reproduce

  1. Using a table with a timestamp column, select conditional formatting from the table sidebar options
  2. Select the timestamp column/
  3. DO NOT ENTER A VALUE
  4. Select a style from the style drop down

Expected results

Nothing, formatting rule preview can't be applied with a value.

Actual results

Table errors, can't recover. Errors with timestamps, but strings are also incorrectly applying as undefined, and numbers as null. We shouldn't attempt to apply previews without a value.

Probably a bug introduced during the typescript conversion.

image

Versions

Engine Version: 0.22.0
Web UI Version: 0.30.0
Java Version: 17.0.6
Barrage Version: 0.5.0

@dsmmcken dsmmcken added bug Something isn't working triage Issue requires triage good first issue Good for newcomers and removed triage Issue requires triage labels Feb 16, 2023
@dsmmcken dsmmcken added this to the February 2023 milestone Feb 16, 2023
@bmingles bmingles self-assigned this Feb 23, 2023
@bmingles
Copy link
Contributor

@dsmmcken I think I have fixed the issue with Date columns. I am not seeing the string + number issue you mentioned

strings are also incorrectly applying as undefined, and numbers as null

@bmingles bmingles linked a pull request Feb 23, 2023 that will close this issue
@dsmmcken
Copy link
Contributor Author

image

For strings: open a table, switch it to a double column, switch it to a string column, hit done.

I can't seem to replicate whatever issue I mentioned with numbers, so maybe I hallucinated that.

bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 24, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants