Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding columns via layout hints in a group rendering bug #1097

Closed
mattrunyon opened this issue Feb 19, 2023 · 0 comments · Fixed by #1139
Closed

Hiding columns via layout hints in a group rendering bug #1097

mattrunyon opened this issue Feb 19, 2023 · 0 comments · Fixed by #1139
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mattrunyon
Copy link
Collaborator

Description

Reported by Kevin S. in the community slack. When creating column header groups and hiding the columns in a group with layout hints, the group header still appears over the group. This does not occur with groups hidden via the side panel.

Steps to reproduce

Use this Python code

from deephaven import new_table
from deephaven.column import string_col, int_col
from deephaven.plot import Colors

letters_and_numbers = new_table([
    string_col("A", ["A", "a"]),
    string_col("B", ["B", "b"]),
    string_col("C", ["C", "c"]),
    string_col("D", ["D", "d"]),
    string_col("E", ["E", "e"]),
    string_col("Y", ["Y", "y"]),
    int_col("Even", [2, 4]),
    int_col("Odd", [1, 3])
])

letters_and_numbers_grouped = letters_and_numbers.layout_hints(
    column_groups=[
        { 'name' : 'Letters', 'children': ['Vowels', 'Y', 'Consonants'], 'color': '#FCD65B' },
        { 'name' : 'Vowels', 'children': ['A', 'E'], 'color': Colors.CORNFLOWERBLUE.to_hex() },
        { 'name' : 'Consonants', 'children': ['B', 'C', 'D'], 'color': 'CORAL' },
        { 'name' : 'Numbers', 'children': ['Even', 'Odd'] }
    ],
    hide=['A', 'E']
)

Expected results

Table with the groups, but the Vowels group is hidden.

Actual results

Table with the groups, the columns in Vowels are hidden, but the Vowels header still appears which makes the group headers over the wrong columns.

Versions

Engine Version: 0.22.0
Web UI Version: 0.30.0
Java Version: 17.0.6
Barrage Version: 0.5.0

@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Feb 19, 2023
@vbabich vbabich added this to the March 2023 milestone Feb 22, 2023
@vbabich vbabich removed the triage Issue requires triage label Feb 22, 2023
mattrunyon added a commit that referenced this issue Mar 8, 2023
…group via layout hints (#1139)

Fixes #1097 

Also updated the readme for updating e2e snapshots and removed some env
variables that shouldn't be needed any more when updating/running e2e
tests

---------

Co-authored-by: mikebender <mikebender@deephaven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants