Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional formatting should not be applied when set to "No formatting" #1106

Closed
bmingles opened this issue Feb 24, 2023 · 0 comments · Fixed by #1107
Closed

Conditional formatting should not be applied when set to "No formatting" #1106

bmingles opened this issue Feb 24, 2023 · 0 comments · Fixed by #1107
Assignees
@bmingles
Labels
bug Something isn't working triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

bmingles commented Feb 24, 2023 •
edited
Loading

Steps to reproduce

  1. Select conditional formatting for a column
  2. Apply a valid condition
  3. Leave "Style" as "No formatting"

Expected results

  1. Done button should remain disabled
  2. After selecting a style, button should be enabled
  3. Changing style back to "No formatting" should disable the button again

Actual results
Done button is enabled when style set to "No formatting"

Versions

Engine Version: 0.22.0
Web UI Version: 0.30.1
Java Version: 17.0.6
Barrage Version: 0.5.0
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Feb 24, 2023
@bmingles bmingles self-assigned this Feb 24, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 24, 2023
@bmingles
fix: Disable applying "No formatting"
a9f96f9 
fixes deephaven#1106
@bmingles bmingles mentioned this issue Feb 24, 2023
Merged
@dsmmcken dsmmcken mentioned this issue Feb 24, 2023
Closed
@bmingles bmingles mentioned this issue Feb 24, 2023
Closed
bmingles added a commit that referenced this issue Feb 27, 2023
@bmingles
fix: Disable applying "No formatting" (#1107)
14020f1 
fixes #1106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Disable applying "No formatting" bmingles/web-client-ui
1 participant
@bmingles