Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicModal - isConfirmDanger prop #1109

Closed
bmingles opened this issue Feb 24, 2023 · 0 comments · Fixed by #1110
Closed

BasicModal - isConfirmDanger prop #1109

bmingles opened this issue Feb 24, 2023 · 0 comments · Fixed by #1110
Assignees
@bmingles
Labels
enhancement New feature or request

Comments

@bmingles
Copy link
Contributor

As a developer I want to be able to configure a basic confirmation dialog for actions that a user wouldn't want to take accidentally.

We should add an optional isConfirmDanger?: boolean prop to the BasicModal component such that if true:

  • The default action is "Cancel"
  • The confirmation button should use the "danger" color

image

If the prop is not set or is set to false, the behavior should be as-is:
image
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Feb 24, 2023
@bmingles bmingles self-assigned this Feb 24, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 24, 2023
@bmingles
feature: isConfirmDangerProp
b6a3bae 
resolves deephaven#1109
@bmingles bmingles mentioned this issue Feb 24, 2023
Merged
@bmingles bmingles removed the triage Issue requires triage label Feb 27, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Feb 27, 2023
@bmingles
fix: Addressed CC comment
d652ffd 
resolves deephaven#1109
bmingles added a commit that referenced this issue Feb 27, 2023
@bmingles
feat: isConfirmDangerProp (#1110)
ffb7ada 
resolves #1109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: isConfirmDangerProp bmingles/web-client-ui
1 participant
@bmingles