Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IrisGrid throws error if given table with no columns #1169

Closed
bmingles opened this issue Mar 22, 2023 · 0 comments · Fixed by #1170 or #1179
Closed

IrisGrid throws error if given table with no columns #1169

bmingles opened this issue Mar 22, 2023 · 0 comments · Fixed by #1170 or #1179
Assignees
@bmingles
Labels
bug Something isn't working triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

Description

IrisGrid throws a .js error if given a table with no columns.

This is the underlying cause of
https://deephaven.atlassian.net/browse/DH-14436

Steps to reproduce
Create a table with no columns

from deephaven import empty_table
x = empty_table(10)

Expected results
Table panel should load without error but show no columns or rows

Actual results
image

Versions

Engine Version: 0.22.0
Web UI Version: 0.31.1
Java Version: 17.0.6
Barrage Version: 0.5.0
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Mar 22, 2023
@bmingles bmingles self-assigned this Mar 22, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Mar 22, 2023
@bmingles
Handling no columns
740ea9b 
deephaven#1169
This was referenced Mar 22, 2023
Merged
Open
bmingles added a commit that referenced this issue Mar 22, 2023
@bmingles
fix: Handling no columns (#1170)
2ac25ae 
Added graceful handling to IrisGrid for tables with no columns.

fixes #1169
vbabich pushed a commit to vbabich/web-client-ui that referenced this issue Mar 28, 2023
@bmingles @vbabich
fix: Handling no columns (deephaven#1170)
17f7431 
Added graceful handling to IrisGrid for tables with no columns.

fixes deephaven#1169
@vbabich vbabich mentioned this issue Mar 28, 2023
Merged
vbabich pushed a commit to vbabich/web-client-ui that referenced this issue Mar 28, 2023
@bmingles @vbabich
fix: Handling no columns (deephaven#1170)
5f1b3f9 
Added graceful handling to IrisGrid for tables with no columns.

fixes deephaven#1169
vbabich added a commit that referenced this issue Mar 28, 2023
@vbabich @bmingles
fix: DH-14436 Handling no columns (#1170) (#1179)
a7498d5 
Cherry-pick #1170

Added graceful handling to IrisGrid for tables with no columns.

fixes #1169

Co-authored-by: Brian Ingles <brianingles@deephaven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
1 participant
@bmingles