Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dependency mapping for @deephaven/react-hooks #1246

Closed
bmingles opened this issue Apr 25, 2023 · 0 comments · Fixed by #1247 or #1248
Closed

Incorrect dependency mapping for @deephaven/react-hooks #1246

bmingles opened this issue Apr 25, 2023 · 0 comments · Fixed by #1247 or #1248
Assignees
@bmingles
Labels
bug Something isn't working triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

Description

Fix dependency mapping in packages/jsapi-components/package.json for @deephaven/react-hooks

Expected results
package.json dependencies should contain:

"@deephaven/react-hooks": "file:../react-hooks"

Actual results

"@deephaven/react-hooks": "file:../log"

Versions

  • Web UI Version: 0.37.0
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Apr 25, 2023
@bmingles bmingles self-assigned this Apr 25, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 25, 2023
@bmingles
Fixed dependency mapping
3d27979 
deephaven#1246
@bmingles bmingles mentioned this issue Apr 25, 2023
Merged
bmingles added a commit that referenced this issue Apr 25, 2023
@bmingles
fix: Fixed dependency mapping (#1247)
1e250a9 
fixes #1246
bmingles added a commit to bmingles/web-client-ui that referenced this issue Apr 25, 2023
@bmingles
Fixed bad dependency in package-lock
43dbc78 
deephaven#1246
@bmingles bmingles mentioned this issue Apr 25, 2023
Merged
bmingles added a commit that referenced this issue Apr 25, 2023
@bmingles
fix: Fixed bad dependency in package-lock (#1248)
8c78177 
fixes #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working triage Issue requires triage
Projects
None yet
Milestone
No milestone
1 participant
@bmingles