Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features available for iframes are not the same as the ide by default #1337

Closed
devinrsmith opened this issue May 31, 2023 · 1 comment · Fixed by #1400
Closed

Features available for iframes are not the same as the ide by default #1337

devinrsmith opened this issue May 31, 2023 · 1 comment · Fixed by #1400
Assignees
@mofojed
Labels
bug Something isn't working
Milestone
June 2023

Comments

@devinrsmith
Copy link
Member

canCopy and canDownloadCsv options are false by default for iframes, as opposed to true by default for the ide. Ideally, there should be parity between the defaults between these use cases.
@devinrsmith devinrsmith added bug Something isn't working triage Issue requires triage labels May 31, 2023
@devinrsmith devinrsmith added this to the June 2023 milestone May 31, 2023
@devinrsmith devinrsmith changed the title Features available for iframes are no the same as the ide by default Features available for iframes are not the same as the ide by default May 31, 2023
@devinrsmith devinrsmith mentioned this issue May 31, 2023
Closed
@devinrsmith
Copy link
Member Author

It looks like this can be worked around by setting a query parameter http://localhost:10000/iframe/table/?name=parquet_table&canDownloadCsv, but I consider this an anti-feature wrt the original intentions (the idea was that the server should control whether or not this is enabled). I think we should get rid of allowing the value to be set by query param (in addition to having the same defaults as ide).

@vbabich vbabich removed the triage Issue requires triage label Jun 7, 2023
@mofojed mofojed mentioned this issue Jul 6, 2023
Merged
mofojed added a commit that referenced this issue Jul 7, 2023
@mofojed
fix: Use user permissions for iframes instead of query parameters (#1400
8cf2bbd 
)

- Add UserUtils for fetching the User.
- Add ServerConfigBootstrap and UserBootstrap to bootstrap those objects
into context.
- Remove query parameters for controlling user function in iframes;
instead it is defined on the server.
- Fixes #1337.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
bug Something isn't working
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

fix: Use user permissions for iframes instead of query parameters mofojed/web-client-ui
3 participants
@vbabich @mofojed @devinrsmith