Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Util - Disable console methods #1369

Closed
bmingles opened this issue Jun 12, 2023 · 0 comments · Fixed by #1370
Closed

Test Util - Disable console methods #1369

bmingles opened this issue Jun 12, 2023 · 0 comments · Fixed by #1370
Assignees
@bmingles
Labels
enhancement New feature or request triage Issue requires triage

Comments

@bmingles
Copy link
Contributor

As a developer, I would like a test util that makes it easy to disable console log in unit tests. This will help with certain cases where 3rd party code includes console.error statements + some other internal use cases where we may want to disable for certain tests.
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Jun 12, 2023
@bmingles bmingles self-assigned this Jun 12, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2023
@bmingles
resolves deephaven#1369 - disableConsoleOutput test util
ee2eea5 
deephaven#1369
@bmingles bmingles mentioned this issue Jun 12, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2023
@bmingles
Added default for disabling log methods
da9fc2f 
deephaven#1369
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2023
@bmingles
Addressed cc comments
a13ba89 
deephaven#1369
bmingles added a commit to bmingles/web-client-ui that referenced this issue Jun 12, 2023
@bmingles
Added PickMethods util type
c104989 
deephaven#1369
bmingles added a commit that referenced this issue Jun 12, 2023
@bmingles
feat: Console output test util (#1370)
626de83 
Console output test util

resolves #1369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Console output test util bmingles/web-client-ui
1 participant
@bmingles