Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns without a sortable attribute should disable sort behaviours #1380

Closed
dsmmcken opened this issue Jun 20, 2023 · 0 comments · Fixed by #1390
Closed

Columns without a sortable attribute should disable sort behaviours #1380

dsmmcken opened this issue Jun 20, 2023 · 0 comments · Fixed by #1390
Assignees
@ethanalvizo
Labels
enhancement New feature or request
Milestone
June 2023

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Jun 20, 2023 •
edited
Loading

Blocked by deephaven/deephaven-core#1914.

Once columns have sortable attributes the UI should disable certain sorting behaviours for grid.

  1. Disable "Sort by" and "Add additional sort" menu options in the column header context menu
    image
  2. Disable the clicking of a column header from triggering a sort
  3. Add "<icon=dhSortSlash> Not sortable" as text to the column tooltip, below where the column frozen text appears.
    image
@dsmmcken dsmmcken added enhancement New feature or request triage Issue requires triage labels Jun 20, 2023
@mofojed mofojed removed the triage Issue requires triage label Jun 20, 2023
@mofojed mofojed assigned ethanalvizo and unassigned mofojed Jun 20, 2023
@mofojed mofojed added this to the June 2023 milestone Jun 20, 2023
@dsmmcken dsmmcken mentioned this issue Jun 20, 2023
Merged
dsmmcken added a commit that referenced this issue Jun 21, 2023
@dsmmcken
feat: add sort-slash icon (#1381)
9a7b910 
Adds `dhSortSlash` icon needed by #1380


![image](https://github.com/deephaven/web-client-ui/assets/1576283/b56d4003-81c2-4c11-a36c-ceac5fa19bb1)
@ethanalvizo ethanalvizo mentioned this issue Jun 28, 2023
Merged
ethanalvizo added a commit that referenced this issue Jul 6, 2023
@ethanalvizo
feat: disable column sorting on unsupported types (#1390)
3a89bbf 
Closes #1380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
enhancement New feature or request
Projects
None yet
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

feat: disable column sorting on unsupported types ethanalvizo/web-client-ui
3 participants
@dsmmcken @mofojed @ethanalvizo