Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing tab with middle mouse button pastes into active monaco editor #1461

Closed
mattrunyon opened this issue Aug 25, 2023 · 4 comments · Fixed by #2240
Closed

Closing tab with middle mouse button pastes into active monaco editor #1461

mattrunyon opened this issue Aug 25, 2023 · 4 comments · Fixed by #2240
Assignees
@mattrunyon
Labels
bug Something isn't working
Milestone
Backlog

Comments

@mattrunyon
Copy link
Collaborator

Description

If a monaco editor is active, closing a golden layout panel with middle mouse button also pastes your clipboard into the active monaco editor.

Steps to reproduce

  1. Open a notebook/table
  2. Focus a monaco editor like the console
  3. Middle click on an open tab to close it

Expected results

  1. Panel closes.

Actual results

  1. Panel closes and clipboard pastes to monaco

Versions

  • Web UI Version: 0.46.0
  • OS: Pop OS (Ubuntu 22.04 based)
  • Browser: Chromium 116.0.5845.96
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Aug 25, 2023
@dsmmcken
Copy link
Contributor

video/gif? I can't reproduce.

@mattrunyon
Copy link
Collaborator Author

simplescreenrecorder-2023-08-25_17.12.20.mp4

It might be linux specific. In the video I just middle clicked on the tab with monaco focused

@dsmmcken
Copy link
Contributor

#552

@mofojed
Copy link
Member

mofojed commented Aug 30, 2023

I can attest it is still a problem even though I can also attest that I have fixed it before. Seems to be Ubuntu specific?

@mofojed mofojed added this to the Backlog milestone Aug 30, 2023
@mofojed mofojed removed the triage Issue requires triage label Aug 30, 2023
@mattrunyon mattrunyon self-assigned this Sep 30, 2024
@mattrunyon mattrunyon mentioned this issue Sep 30, 2024
Merged
mattrunyon added a commit that referenced this issue Oct 1, 2024
@mattrunyon
fix: Closing tab with middle mouse on Linux pasting into active editor (
91bd8fe 
#2240)

Fixes #1461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattrunyon mattrunyon

Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: Closing tab with middle mouse on Linux pasting into active editor mattrunyon/web-client-ui
3 participants
@dsmmcken @mofojed @mattrunyon