Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monaco autocomplete colors are incorrect #1592

Closed
mattrunyon opened this issue Oct 20, 2023 · 1 comment · Fixed by #1594 or deephaven/deephaven-core#4712
Closed

Monaco autocomplete colors are incorrect #1592

mattrunyon opened this issue Oct 20, 2023 · 1 comment · Fixed by #1594 or deephaven/deephaven-core#4712
Assignees
@bmingles
Labels
bug Something isn't working

Comments

@mattrunyon
Copy link
Collaborator

mattrunyon commented Oct 20, 2023 •
edited
Loading

--dh-color-editor-suggest-fg should be --dh-color-white. Right now we end up w/ black on gray text.

image

We should also probably add a variable to set --vscode-editorSuggestWidget-selectedForeground to --dh-color-white as well. It is currently set to #ffffff by monaco. This affects the color of the non-matching portion when there is keyboard selection on an autocomplete item.

Might want to set something for the blue colors used in selected/non-selected suggestions as well. Those are --vscode-editorSuggestWidget-highlightForeground and --vscode-editorSuggestWidget-focusHighlightForeground

Versions

  • Web UI Version: 0.50.0
@mattrunyon mattrunyon added the bug Something isn't working label Oct 20, 2023
@bmingles
Copy link
Contributor

Found a "complete" list of Monaco theme variables in an old PR
microsoft/monaco-editor#2622 (comment)

bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Adjusted Monaco "white" colors
e7147bc 
deephaven#1592
@bmingles bmingles mentioned this issue Oct 20, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 20, 2023
@bmingles
Added Monaco focus highlight color
8101f9f 
deephaven#1592
bmingles added a commit that referenced this issue Oct 23, 2023
@bmingles
fix: Adjusted Monaco "white" colors (#1594)
c736708 
This fixes some Monaco suggestion colors

<img width="486" alt="image"
src="https://github.com/deephaven/web-client-ui/assets/1900643/8e550d37-5da5-4e9f-a5c4-1ea95a2e5c0b">

fixes #1592
@mofojed mofojed mentioned this issue Oct 24, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Oct 25, 2023
@github-actions @deephaven-internal
Update web version 0.51.0 (#4712)
8e63c05 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.51.0

# [0.51.0](deephaven/web-client-ui@v0.50.0...v0.51.0) (2023-10-24)


### Bug Fixes

* Adjusted Monaco "white" colors ([#1594](deephaven/web-client-ui#1594)) ([c736708](deephaven/web-client-ui@c736708)), closes [#1592](deephaven/web-client-ui#1592)
* cap width of columns with long names ([#1574](deephaven/web-client-ui#1574)) ([876a6ac](deephaven/web-client-ui@876a6ac)), closes [#1276](deephaven/web-client-ui#1276)
* Enabled pointer capabilities for Firefox in Playwright ([#1589](deephaven/web-client-ui#1589)) ([f440a38](deephaven/web-client-ui@f440a38)), closes [#1588](deephaven/web-client-ui#1588)
* Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list ([#1596](deephaven/web-client-ui#1596)) ([7b59763](deephaven/web-client-ui@7b59763)), closes [#1593](deephaven/web-client-ui#1593)
* Tab in console input triggers autocomplete instead of indent ([#1591](deephaven/web-client-ui#1591)) ([fbe1e70](deephaven/web-client-ui@fbe1e70))


### Features

* Theming - Spectrum Provider ([#1582](deephaven/web-client-ui#1582)) ([a4013c0](deephaven/web-client-ui@a4013c0)), closes [#1543](deephaven/web-client-ui#1543)
* Theming Iris Grid ([#1568](deephaven/web-client-ui#1568)) ([ed8f4b7](deephaven/web-client-ui@ed8f4b7))
* web-client-ui changes required for deephaven.ui ([#1567](deephaven/web-client-ui#1567)) ([94ab25c](deephaven/web-client-ui@94ab25c))
* Widget plugins ([#1564](deephaven/web-client-ui#1564)) ([94cc82c](deephaven/web-client-ui@94cc82c)), closes [#1455](deephaven/web-client-ui#1455) [#1167](deephaven/web-client-ui#1167)


### BREAKING CHANGES

- `usePlugins` and `PluginsContext` were moved from
`@deephaven/app-utils` to `@deephaven/plugin`.
- `useLoadTablePlugin` was moved from `@deephaven/app-utils` to
`@deephaven/dashboard-core-plugins`.
- `useConnection` and `ConnectionContext` were moved from
`@deephaven/app-utils` to `@deephaven/jsapi-components`.
- `DeephavenPluginModuleMap` was removed from `@deephaven/redux`. Use
`PluginModuleMap` from `@deephaven/plugin` instead.
* Enterprise will need ThemeProvider for the css
variables to be available





Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@bmingles @mattrunyon