Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open file blocks logout #1685

Closed
bmingles opened this issue Dec 11, 2023 · 2 comments · Fixed by #2281
Closed

Open file blocks logout #1685

bmingles opened this issue Dec 11, 2023 · 2 comments · Fixed by #2281
Assignees
@stevenwu15
Labels
bug Something isn't working
Milestone
October 2024

Comments

@bmingles
Copy link
Contributor

Description

It seems that having an open file stops logout from working.

Steps to reproduce

  • Run DHC such that it requires PSK for login
  • Login
  • Open a file
  • Try logging out. It should fail
  • Close the file
  • Try logging out again. It should succeed

Expected results

Logout should always work

Actual results

Logout only succeeds when no files are open

Versions

Engine Version: 0.31.0-SNAPSHOT
Web UI Version: 0.56.0
Java Version: 21.0.1
Barrage Version: 0.6.0
@bmingles bmingles added bug Something isn't working triage Issue requires triage labels Dec 11, 2023
@bmingles bmingles mentioned this issue Dec 11, 2023
Closed
@vbabich vbabich added this to the December 2023 milestone Dec 12, 2023
@vbabich vbabich removed the triage Issue requires triage label Dec 12, 2023
@mofojed mofojed modified the milestones: December 2023, January 2024 Jan 9, 2024
@bmingles bmingles mentioned this issue Jan 11, 2024
Merged
bmingles added a commit that referenced this issue Jan 22, 2024
@bmingles
fix: Handle undefined DashboardData props (#1726)
45fa929 
- Handle undefined props on DashboardData. Don't render console panel if
no session
- Fixed a set state on unmounted HeapUsage bug
- Removed chatty async interval debug logging

fixes #1684

**Testing**
- Run server with PSK enabled
- Login and open any file
- Logout should no longer show "ConsolePanel.tsx:372 Uncaught TypeError:
Cannot destructure property 'config' of 'sessionWrapper' as it is
undefined." error in debug console (Note that login will still fail
until #1685 is done)
@stevenwu15 stevenwu15 mentioned this issue Jan 23, 2024
Closed
@mofojed mofojed mentioned this issue Jan 26, 2024
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Jan 26, 2024
@github-actions @deephaven-internal
Update web version 0.60.0 (#5078)
2e747b4 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.60.0

# [0.60.0](deephaven/web-client-ui@v0.59.0...v0.60.0) (2024-01-26)


### Bug Fixes

* Fix useDeferredApi export ([#1742](deephaven/web-client-ui#1742)) ([af5f5f4](deephaven/web-client-ui@af5f5f4))
* Handle undefined DashboardData props ([#1726](deephaven/web-client-ui#1726)) ([45fa929](deephaven/web-client-ui@45fa929586c0b13a738eceaa064b261eecbd8308))(https://github.com/deephaven/web-client-ui/issues/1684) [#1685](deephaven/web-client-ui#1685)
* hcm caret shouldn't be allowed to shrink ([#1733](deephaven/web-client-ui#1733)) ([6547814](deephaven/web-client-ui@6547814))
* keep manually entered value in GoToRow when changing to same column type ([#1743](deephaven/web-client-ui#1743)) ([689a1e2](deephaven/web-client-ui@689a1e2))
* loading spinner finishes before all series load ([#1729](deephaven/web-client-ui#1729)) ([e79297b](deephaven/web-client-ui@e79297b))


### Features

* Add pluginDataMap to redux, add useDashboardPluginData hook ([#1737](deephaven/web-client-ui#1737)) ([e1b4562](deephaven/web-client-ui@e1b4562))
* added shortcut for copying version info and added browser/os to info ([#1739](deephaven/web-client-ui#1739)) ([3312133](deephaven/web-client-ui@3312133))
* Adds icons dhUnderline and dhStrikethrough ([#1732](deephaven/web-client-ui#1732)) ([c6a099d](deephaven/web-client-ui@c6a099d))
* adjust display of  theme palette in styleguide ([#1745](deephaven/web-client-ui#1745)) ([0ab0c93](deephaven/web-client-ui@0ab0c93))
* Create UI to Display Partitioned Tables ([#1663](deephaven/web-client-ui#1663)) ([db219ca](deephaven/web-client-ui@db219ca))
* Default Plotly map colors ([#1721](deephaven/web-client-ui#1721)) ([e8b9f12](deephaven/web-client-ui@e8b9f12))
* double-clicking grid rows should select the row rather than toggle selection twice ([#1740](deephaven/web-client-ui#1740)) ([f892e97](deephaven/web-client-ui@f892e97))
* Multiple dashboards ([#1714](deephaven/web-client-ui#1714)) ([32dde3c](deephaven/web-client-ui@32dde3c))

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
@mofojed mofojed modified the milestones: January 2024, February 2024 Feb 13, 2024
@mofojed mofojed modified the milestones: February 2024, March 2024 Mar 12, 2024
@mofojed mofojed modified the milestones: March 2024, April 2024 Apr 12, 2024
@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
@mofojed mofojed modified the milestones: July 2024, September 2024 Sep 3, 2024
@mofojed mofojed mentioned this issue Oct 22, 2024
Open
@mofojed
Copy link
Member

mofojed commented Oct 29, 2024

Would be nice to take another look at this. The RefreshTokenBootstrap has been removed.

@mofojed mofojed modified the milestones: September 2024, October 2024 Oct 29, 2024
@bmingles
Copy link
Contributor Author

bmingles commented Nov 1, 2024

@mofojed This still seems to be reproducible on ghcr.io/deephaven/server-slim:edge

@stevenwu15 stevenwu15 mentioned this issue Nov 6, 2024
Merged
@stevenwu15 stevenwu15 self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenwu15 stevenwu15

Labels
bug Something isn't working
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

fix: open file blocks logout stevenwu15/web-client-ui
fix: allow logout on open file
4 participants
@bmingles @vbabich @mofojed @stevenwu15