Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH-16532: Hide the "Expand row and all children" shortcut if the expandAll function isn't available #1822

Closed
vbabich opened this issue Feb 21, 2024 · 2 comments · Fixed by #1854
Closed

DH-16532: Hide the "Expand row and all children" shortcut if the expandAll function isn't available #1822

vbabich opened this issue Feb 21, 2024 · 2 comments · Fixed by #1854
Assignees
@wusteven815
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
March 2024

Comments

@vbabich
Copy link
Collaborator

vbabich commented Feb 21, 2024 •
edited
Loading

Legacy tree tables don’t have the JsTreeTable.expandAll function. TreeTable row tooltip in IrisGrid should show the shortcut to expand the row and all children conditionally, based on feature availability.
Screenshot 2024-02-21 at 12 52 36 PM
@vbabich vbabich added bug Something isn't working triage Issue requires triage good first issue Good for newcomers and removed triage Issue requires triage labels Feb 21, 2024
@vbabich vbabich added this to the March 2024 milestone Feb 27, 2024
@mofojed
Copy link
Member

mofojed commented Feb 29, 2024

Should just not show that text if !model.isExpandAllAvailable

@mofojed
Copy link
Member

mofojed commented Feb 29, 2024

Create a tree table using a snippet from the docs: https://deephaven.io/core/docs/reference/cheat-sheets/cheat-sheet/#tree-tables

from deephaven.constants import NULL_INT
from deephaven import empty_table

source = empty_table(100).update_view(["ID = i", "Parent = i == 0 ? NULL_INT : (int)(i / 4)"])

result = source.tree(id_col="ID", parent_col="Parent")

@wusteven815 wusteven815 mentioned this issue Mar 6, 2024
Merged
wusteven815 added a commit that referenced this issue Mar 8, 2024
@wusteven815
fix: hide expand all when not available (#1854)
aa34ace 
- Fix #1822 
  - Add a check for `isExpandAllAvailable` to render the list on the
tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wusteven815 wusteven815

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
March 2024
Development

Successfully merging a pull request may close this issue.

fix: hide expand all when not available
3 participants
@vbabich @mofojed @wusteven815