Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH-16230: Unable to select a deselected leaf in HierarchicalCheckboxMenu #1856

Closed
vbabich opened this issue Mar 7, 2024 · 0 comments · Fixed by #1956 or deephaven/deephaven-core#5406
Closed

DH-16230: Unable to select a deselected leaf in HierarchicalCheckboxMenu #1856

vbabich opened this issue Mar 7, 2024 · 0 comments · Fixed by #1956 or deephaven/deephaven-core#5406
Assignees
@wusteven815
Labels
bug Something isn't working
Milestone
April 2024

Comments

@vbabich
Copy link
Collaborator

vbabich commented Mar 7, 2024

Steps to reproduce

  1. Open a HierarchicalCheckboxMenu, de-select a leaf
  2. Click the leaf checkbox to select again

Expected results
Leaf is selected

Actual results
Leaf is not selected

Additional details and attachments

8e4d2fa3-3584-4f51-81bd-8ed76044fb29

Versions

  • Web UI Version: 0.66.1
@vbabich vbabich added bug Something isn't working triage Issue requires triage labels Mar 7, 2024
@vbabich vbabich added this to the March 2024 milestone Mar 12, 2024
@vbabich vbabich removed the triage Issue requires triage label Mar 12, 2024
@mofojed mofojed modified the milestones: March 2024, April 2024 Apr 12, 2024
@wusteven815 wusteven815 mentioned this issue Apr 22, 2024
Merged
wusteven815 added a commit that referenced this issue Apr 24, 2024
@wusteven815
fix: unable to select deselected leaf (#1956)
f5d622a 
- Fix #1856 
- Fix boolean logic
@mofojed mofojed mentioned this issue Apr 24, 2024
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Apr 24, 2024
@github-actions @deephaven-internal
Update web version 0.74.0 (#5406)
8becc41 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.74.0

# [0.74.0](deephaven/web-client-ui@v0.73.0...v0.74.0) (2024-04-24)

### Bug Fixes

* unable to select deselected leaf ([#1956](deephaven/web-client-ui#1956)) ([f5d622a](deephaven/web-client-ui@f5d622a)), closes [#1856](deephaven/web-client-ui#1856)


### Features

* Add DashboardPlugin support to embed-widget ([#1950](deephaven/web-client-ui#1950)) ([27fc8bd](deephaven/web-client-ui@27fc8bd))
* replace code studio home icon with "Code Studio" as label ([#1951](deephaven/web-client-ui#1951)) ([111ea64](deephaven/web-client-ui@111ea64)), closes [#1794](deephaven/web-client-ui#1794)

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wusteven815 wusteven815

Labels
bug Something isn't working
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

fix: unable to select deselected leaf
Update web version 0.74.0 deephaven/deephaven-core
3 participants
@vbabich @mofojed @wusteven815