-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve loading state while seeking table #1865
Closed
mofojed opened this issue
Mar 11, 2024
· 0 comments
· Fixed by #1898 or deephaven/deephaven-core#5387
Closed
Improve loading state while seeking table #1865
mofojed opened this issue
Mar 11, 2024
· 0 comments
· Fixed by #1898 or deephaven/deephaven-core#5387
Comments
dsmmcken
changed the title
Viewport loading state on tables
Improve loading state while seeking table
Mar 11, 2024
wusteven815
added a commit
that referenced
this issue
Apr 11, 2024
- Adds #1865 - Add a check for if there is still data being loaded in the viewport - Add a new loading message if the above is true for >500ms - Add state to determine whether `startLoading` will block the grid or show the cancel button
mofojed
pushed a commit
to deephaven/deephaven-core
that referenced
this issue
Apr 24, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.73.0 # [0.73.0](deephaven/web-client-ui@v0.72.0...v0.73.0) (2024-04-19) ### Bug Fixes * allow plotly plots to shrink inside ui.flex/grid layouts ([#1946](deephaven/web-client-ui#1946)) ([88fbe86](deephaven/web-client-ui@88fbe86)) * Fix issues when auto-size columns/rows is false, and when row headers are not 0 ([#1927](deephaven/web-client-ui#1927)) ([01c2a06](deephaven/web-client-ui@01c2a06)) ### Features * improve table loading ([#1898](deephaven/web-client-ui#1898)) ([9b14ee0](deephaven/web-client-ui@9b14ee0)), closes [#1865](deephaven/web-client-ui#1865) * ListView components ([#1919](deephaven/web-client-ui#1919)) ([b63ab18](deephaven/web-client-ui@b63ab18)) * log export blacklist ([#1881](deephaven/web-client-ui#1881)) ([d3fb28a](deephaven/web-client-ui@d3fb28a)), closes [#1245](deephaven/web-client-ui#1245) * New chart error panel ([#1850](deephaven/web-client-ui#1850)) ([309ff79](deephaven/web-client-ui@309ff79)), closes [#1520](deephaven/web-client-ui#1520) * reopen closed tabs ([#1912](deephaven/web-client-ui#1912)) ([c2e8714](deephaven/web-client-ui@c2e8714)), closes [#1785](deephaven/web-client-ui#1785) ### BREAKING CHANGES * `LIST_VIEW_ROW_HEIGHT` number constant replaced with dictionary `LIST_VIEW_ROW_HEIGHTS` Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When scrolling with a large table from a slow backend (or has slow to compute rows), if the data takes a long time to come in, the grid just appears blank and there is no loading indicator. We should have some sort of subtle loading indicator to show there is still a request in progress, "Waiting for viewport...".
Suggested fix:
Display a status message (the
loadingtext
at bottom of table) with a delay of ~0.5s before showing. We don’t want the loader to show in most scenarios, because it’s normally snappy. Show the text “Waiting for viewport…” with the back and forth loader.Example query (slow when scrolling because of sleep):
The text was updated successfully, but these errors were encountered: