Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required checks are not enforced properly for e2e #2044

Closed
mattrunyon opened this issue May 29, 2024 · 0 comments · Fixed by #2045
Closed

Required checks are not enforced properly for e2e #2044

mattrunyon opened this issue May 29, 2024 · 0 comments · Fixed by #2045
Labels
bug Something isn't working

Comments

@mattrunyon
Copy link
Collaborator

Our required build/e2e test seems to only be requiring the build step actually pass. This was probably broken when we changed to a matrix job as it used to be just 1 job instead of multiple jobs in a workflow.

Should be able to test by introducing a bad/failing e2e test. Notice how in these images the required test is passed, but there are later steps that failed.

We probably need to have the final step of merging the reports be the required check.

image
image
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels May 29, 2024
@mattrunyon mattrunyon mentioned this issue May 29, 2024
Merged
mofojed pushed a commit that referenced this issue May 30, 2024
@mattrunyon
fix: e2e test status reporting incorrectly (#2045)
8e6b6da 
Fixes #2044

Infra PR deephaven/infra#301

You can see the e2e-results job failed on my 2nd commit to this PR. It
should fail if any of the matrix jobs fail or are cancelled.
mofojed pushed a commit to mofojed/web-client-ui that referenced this issue Jun 3, 2024
@mattrunyon @mofojed
fix: e2e test status reporting incorrectly (deephaven#2045)
f621c29 
Fixes deephaven#2044

Infra PR deephaven/infra#301

You can see the e2e-results job failed on my 2nd commit to this PR. It
should fail if any of the matrix jobs fail or are cancelled.
@mofojed mofojed mentioned this issue Jun 3, 2024
Merged
mofojed added a commit that referenced this issue Jun 3, 2024
@mofojed @mattrunyon
fix: e2e test status reporting incorrectly (#2045) (#2051)
859063e 
Fixes #2044

Infra PR deephaven/infra#301

You can see the e2e-results job failed on my 2nd commit to this PR. It
should fail if any of the matrix jobs fail or are cancelled.

Co-authored-by: Matthew Runyon <matthewrunyon@deephaven.io>
@mattrunyon mattrunyon removed the triage Issue requires triage label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: e2e test status reporting incorrectly mattrunyon/web-client-ui
1 participant
@mattrunyon