Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IrisGrid - don't stop propagation of scroll events when scroll position is at a boundary #2101

Closed
bmingles opened this issue Jun 25, 2024 · 0 comments · Fixed by #2166
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link
Contributor

bmingles commented Jun 25, 2024

IrisGrid currently handles scroll events when cursor is over the grid. This behaves as expected when there is scrollable data. The user scrolls and sees the table scroll accordingly. In cases where there are too few rows to scroll or when there are no more rows to scroll in the target direction, no UI change occurs when the user scrolls, and the scroll event is swallowed by the component. This can be confusing if the user is scrolling a long page that happens to contain IrisGrid examples (e.g. deephaven.io). The page scrolls until the cursor ends up over an IrisGrid example in which case the page stops scrolling. If the grid is not scrollable, the lack of UI change gives the impression that the UI has locked up somehow.

Proposed solution would be to only stop propagation of scroll events that would result in scroll position changes.

  • If table has no scrollable data, propagate the event
  • If table has no more rows in the direction the user is attempting to scroll, propagate the event
  • If table will scroll in some way in response to the event, stop propagation
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Jun 25, 2024
@dsmmcken dsmmcken changed the title IrisGrid - don't swallow scroll events when scroll position is at a boundary IrisGrid - don't stop propagation of scroll events when scroll position is at a boundary Jun 25, 2024
@mofojed mofojed removed the triage Issue requires triage label Jun 25, 2024
@mofojed mofojed added this to the July 2024 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants