feat: Ruff Python formatter and linter #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1255 I need to test this doesn't crash if using groovy. Not sure if the ruff version is available without initializing ruff first or what happens if it's unavailable. - Added global setting for minimap, format on save, formatter, and formatting settings - Added format on save option and format button to notebook overflow menu - Format on save triggers on both shortcut and pressing the save button - Config editor has JSON schema included - Config editor cannot be closed by clicking outside the modal, but can be closed w/ escape key Something we should add maybe as part of this PR or a final follow-up to this feature branch is disabling certain/all linting/formatting for the console. One way we might do this is by registering the console w/ a specific URI or URI scheme so we can check it when checking if we should lint. Or include it as a prop to the `MonacoProviders` component. This would require some changes to the current setup of setting/using the config on `MonacoProviders` static members/methods (This might not actually be breaking, it's more just notes for implementing in DHE) BREAKING CHANGE: The app should call `MonacoUtils.init` with a `getWorker` function that uses the JSON worker in addition to the general fallback worker when adding support for configuring ruff.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 46.61% 46.58% -0.03%
==========================================
Files 692 698 +6
Lines 38508 39238 +730
Branches 9826 10098 +272
==========================================
+ Hits 17949 18280 +331
- Misses 20506 20945 +439
+ Partials 53 13 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
previously approved these changes
Sep 24, 2024
mofojed
approved these changes
Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1255
(This might not actually be breaking, it's more just notes for implementing in DHE)
BREAKING CHANGE:
The app should call
MonacoUtils.initwith agetWorkerfunction that uses the JSON worker in addition to the general fallback worker when adding support for configuring ruff.